Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add outdated version info to troubleshooting guide #2060

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented May 16, 2024

Partially addresses #1945

@andyw8 andyw8 requested a review from a team as a code owner May 16, 2024 18:16
@andyw8 andyw8 requested review from st0012 and vinistock May 16, 2024 18:16
@andyw8 andyw8 force-pushed the andyw8/add-outdated-version-troubleshooting-notes branch 3 times, most recently from ff05304 to 83d5878 Compare May 16, 2024 18:19
@andyw8 andyw8 requested review from dirceu and egiurleo May 16, 2024 18:27
@andyw8 andyw8 force-pushed the andyw8/add-outdated-version-troubleshooting-notes branch 2 times, most recently from 6339750 to 5ae2b6d Compare May 16, 2024 18:34
@andyw8 andyw8 force-pushed the andyw8/add-outdated-version-troubleshooting-notes branch from 5ae2b6d to fdf122c Compare May 16, 2024 18:38
Copy link
Contributor

@dirceu dirceu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't have to be on this PR, but it might be good to add a table of contents on this page; the content is getting pretty big and it's not that easy to skim.

@@ -160,6 +160,36 @@ ruby-lsp
Is there any extra information given from booting the server manually? Or does it only fail when booting through the
extension?

### Outdated Version
Copy link
Contributor

@dirceu dirceu May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is under Diagnosing the problem; would it make sense to move it to under Common issues?

TROUBLESHOOTING.md Outdated Show resolved Hide resolved
TROUBLESHOOTING.md Outdated Show resolved Hide resolved
andyw8 and others added 2 commits May 16, 2024 14:40
Co-authored-by: Dirceu Pereira Tiegs <dirceutiegs@gmail.com>
Co-authored-by: Dirceu Pereira Tiegs <dirceutiegs@gmail.com>
@andyw8 andyw8 added documentation Improvements or additions to documentation server This pull request should be included in the server gem's release notes labels May 16, 2024
TROUBLESHOOTING.md Outdated Show resolved Hide resolved
TROUBLESHOOTING.md Outdated Show resolved Hide resolved
Comment on lines +59 to +66
**How to solve it**

You can add a dependency constraint to your Gemfile limiting the Prism version to that maximum supported by Ruby LSP.
For example:

```
gem "prism", "< 0.28" # example for Ruby LSP v0.16.6
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we want to tell folks to pin their Prism version. Once Prism v1 is out, we will relax our constraints and the issue will be greatly mitigated. Then how do we tell everybody to remove this from their gemfiles?

Copy link
Contributor Author

@andyw8 andyw8 May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's not ideal. But in that time between a Prism release and the update to Ruby LSP, it's a lousy experience for developers.

One way to mitigate this could be align with Kevin so that when the next Prism release is ready, we verify it and pre-emptively bump the constraint a day or two before the actual Prism release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might be a smoother option. Also, my understanding is that Prism is almost there with the v1.0.0, so this problem might be resolved very soon.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next release is going to be v1.0.0, so I'll let you know before it goes out and we can test it.

andyw8 and others added 2 commits May 28, 2024 11:27
Co-authored-by: Vinicius Stock <vinistock@users.noreply.github.com>
Co-authored-by: Vinicius Stock <vinistock@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation server This pull request should be included in the server gem's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants