Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make sure stdout is clean during all request processing
RuboCop is still too chatty and breaks the protocol by printing to stdout despite our best attempts. Today I was having problems with the formatting on Tapioca and realized it was because of the: ``` An error occurred while Layout/BlockEndNewline cop was inspecting /Users/ufuk/src/github.com/Shopify/tapioca/lib/tapioca/static/rbs_converter.rb:166:8. To see the complete backtrace run rubocop -d. ``` problem (which is in per-1.34 versions of RuboCop). I am not exactly sure why this was causing a problem, since that specific message should be going to stderr, but the LSP communication was still broken because of it. Regardless, I realized that we never want any request to print to stdout, willingly or by mistake, so I decided to resolve that at the handler layer.
- Loading branch information