Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove jcenter from android repositories #1040

Merged
merged 3 commits into from
Nov 7, 2022

Conversation

Nodonisko
Copy link
Contributor

@Nodonisko Nodonisko commented Oct 31, 2022

This should fix build for Android because jcenter was shutdown.

fixes #1039

This should fix build for Android because jcenter was shutdown.
@Nodonisko
Copy link
Contributor Author

I replaced whole repositories section with same that default RN template use.

@wcandillon
Copy link
Collaborator

Thks for doing this! Just out of curiosity, any reason why I am not experiencing a build failure due to jcenter being offline. Is it offline?

@Nodonisko
Copy link
Contributor Author

Honestly I am not sure. I have problems to find exact information when jcenter exactly will be offline completely. I guess it could be some kind of cache of maybe servers for your location still works...

For us build started to fail everywhere. Did you tried to build lib itself or app that is using library?

@philippeauriach
Copy link

We had the same problems, on multiple apps, but only when building in "release" mode. Building locally in android studio would work, but taking a long time. I don't have any clear information neither, but I too suspect some local cache or fallback

Copy link
Collaborator

@chrfalch chrfalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this looks good to me, I've gone through and compared to the current RN files as well and it makes sense.

@wcandillon wcandillon merged commit 812536a into Shopify:main Nov 7, 2022
@wcandillon
Copy link
Collaborator

Thank You @Nodonisko!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build doesn't work on Android because of JCenter shut down
5 participants