You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For Expo Web, we don't transpile all modules in node_modules for bundling performance. We found a regression for react-native-skia between 0.1.141 to 0.1.155. the nullish coalescing operators don't be transpiled. it's not clear whether there's some change in react-native-skia or simply because the browserslist of react-native-builder-bob updates. unfortunately, expo web still use webpack 4 and webpack 4 doesn't support nullish coalescing operators even latest browsers support them.
node_modules/@shopify/react-native-skia/lib/module/animation/spring/useSpring.js in 0.1.141
add import { WithSkiaWeb } from '@shopify/react-native-skia/lib/module/web'; in App.js and reload the webpage, you should able to see the error in devtools.
Snack, code example, screenshot, or link to a repository
this is the App.js i had in the repro above.
import{StatusBar}from'expo-status-bar';import{StyleSheet,Text,View}from'react-native';import{WithSkiaWeb}from'@shopify/react-native-skia/lib/module/web';exportdefaultfunctionApp(){return(<Viewstyle={styles.container}><Text>Open up App.js to start working on your app!</Text><StatusBarstyle="auto"/></View>);}conststyles=StyleSheet.create({container: {flex: 1,backgroundColor: '#fff',alignItems: 'center',justifyContent: 'center',},});
The text was updated successfully, but these errors were encountered:
# Why
fixShopify/react-native-skia#1030 for sdk 47
# How
- there're no meaningful native changes from 0.1.155 to 0.1.157, so we just update the _bundledNativeModules.json_
- revert the NCL webpack workaround from #19717
# Test Plan
- tested on sdk 47 expo go + @shopify/react-native-skia@0.1.157
- NCL ci passed
- NCL - `yarn build:web`
Description
For Expo Web, we don't transpile all modules in node_modules for bundling performance. We found a regression for react-native-skia between 0.1.141 to 0.1.155. the nullish coalescing operators don't be transpiled. it's not clear whether there's some change in react-native-skia or simply because the browserslist of react-native-builder-bob updates. unfortunately, expo web still use webpack 4 and webpack 4 doesn't support nullish coalescing operators even latest browsers support them.
node_modules/@shopify/react-native-skia/lib/module/animation/spring/useSpring.js
in 0.1.141node_modules/@shopify/react-native-skia/lib/module/animation/spring/useSpring.js
in 0.1.155hopefully you could have a custom babel config for react-native-builder-blob to transpile nullish coalescing operators to support expo web.
Version
0.1.155
Steps to reproduce
the issue is also reproducible on expo sdk 46 project.
$ yarn create expo-app -t blank@sdk-46 sdk46 $ cd sdk46 $ npx expo install react-native-web@~0.18.7 react-dom@18.0.0 @expo/webpack-config@^0.17.0 $ yarn add @shopify/react-native-skia@0.1.155 $ yarn setup-skia-web $ npx expo start -w
add
import { WithSkiaWeb } from '@shopify/react-native-skia/lib/module/web';
in App.js and reload the webpage, you should able to see the error in devtools.Snack, code example, screenshot, or link to a repository
this is the App.js i had in the repro above.
The text was updated successfully, but these errors were encountered: