Fix esm builds incorrectly containing .js files instead of .mjs files #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This release of rollup contains a fix that means babel helpers in the esm build get generated with a .mjs extension, rather than a .js extension. This fixes an error that occures when trying to use the esm build in node. See rollup/plugins#1031
BPScott
force-pushed
the
fix-virtual-filenames
branch
from
ee7bb95
to
7db3ee1
Compare
dahukish
reviewed
Nov 22, 2021
|
|
||
| ### Changed | ||
|
|
||
| - Fixed babel helpers file being generated with incorrect filename in esm build. [[#2082](https://github.com/Shopify/quilt/pull/2082)] |
vsumner
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the rollup version to 2.60.1.
This release of rollup contains a fix that means babel helpers in the esm build now get generated with a .mjs extension, rather than a .js extension.
This fixes an error that occurs when trying to use the esm build in node. See rollup/plugins#1031 and rollup/rollup#4270
Type of change
Patch:
@shopify/address@shopify/ast-utilities@shopify/async@shopify/dates@shopify/graphql-config-utilities@shopify/graphql-fixtures@shopify/graphql-mini-transforms@shopify/graphql-persisted@shopify/graphql-testing@shopify/graphql-typescript-definitions@shopify/graphql-validate-fixtures@shopify/jest-dom-mocks@shopify/jest-koa-mocks@shopify/logger@shopify/performance@shopify/react-app-bridge-universal-provider@shopify/react-async@shopify/react-bugsnag@shopify/react-cookie@shopify/react-effect@shopify/react-form-state@shopify/react-form@shopify/react-graphql-universal-provider@shopify/react-graphql@shopify/react-html@shopify/react-i18n-universal-provider@shopify/react-i18n@shopify/react-import-remote@shopify/react-network@shopify/react-performance@shopify/react-router@shopify/react-server@shopify/react-shortcuts@shopify/react-testing@shopify/semaphore@shopify/statsd@shopify/web-worker