Fix CI errors on master #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmartin
force-pushed
the
fix-type-errors
branch
2 times, most recently
from
ac08145
to
51d01e7
Compare
added 2 commits
April 10, 2019 12:07
sebmartin
force-pushed
the
fix-type-errors
branch
from
51d01e7
to
28dc9a5
Compare
added 3 commits
April 10, 2019 12:13
sebmartin
force-pushed
the
fix-type-errors
branch
from
38e67c4
to
6168299
Compare
Closed
Yeah I like that better 👍 |
cfournie
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterhas been failing for a while with type errors. This attempts to fix them.https://travis-ci.org/Shopify/pyoozie/jobs/380235270#L971-L1034
Also mypy stopped supporting python 3.4 about two weeks ago.