Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk Action Button intro animation #11798

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mrcthms
Copy link
Contributor

@mrcthms mrcthms commented Mar 28, 2024

WHY are these changes introduced?

Fixes https://github.com/Shopify/web/issues/122215

Adds a subtle animation to the bulk action buttons when they mount, with the aim of increasing discoverability for merchants.

Spin URL: https://admin.web.bulk-action-button-animation.marc-thomas.eu.spin.dev/store/shop1/orders

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

@mrcthms
Copy link
Contributor Author

mrcthms commented Mar 28, 2024

/snapit

Copy link
Contributor

🫰✨ Thanks @mrcthms! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/polaris-migrator@0.0.0-snapshot-20240328133448
yarn add @shopify/polaris@0.0.0-snapshot-20240328133448
yarn add @shopify/stylelint-polaris@0.0.0-snapshot-20240328133448

@mrcthms mrcthms force-pushed the mrcthms-bulk-actions-animation branch from bbcb7d3 to 16fde4c Compare April 3, 2024 09:24
@mrcthms
Copy link
Contributor Author

mrcthms commented Apr 4, 2024

/snapit

Copy link
Contributor

github-actions bot commented Apr 4, 2024

🫰✨ Thanks @mrcthms! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/polaris-migrator": "0.0.0-snapshot-20240404084138"
"@shopify/polaris": "0.0.0-snapshot-20240404084138"

@mrcthms mrcthms force-pushed the mrcthms-bulk-actions-animation branch from 16fde4c to 74df8df Compare April 8, 2024 14:36
@mrcthms
Copy link
Contributor Author

mrcthms commented Apr 8, 2024

/snapit

Copy link
Contributor

github-actions bot commented Apr 8, 2024

🫰✨ Thanks @mrcthms! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/polaris-migrator": "0.0.0-snapshot-20240408144343"
"@shopify/polaris": "0.0.0-snapshot-20240408144343"

@mrcthms mrcthms changed the title [WIP] Bulk Action Button intro animation Bulk Action Button intro animation Apr 8, 2024
@github-actions github-actions bot added the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label Apr 19, 2024
@translation-platform
Copy link
Contributor

Localization quality issues found

The following issues may affect the quality of localized translations if they are not addressed:

  • The value Clear for key Polaris.ActionList.SearchField.clearButtonLabel is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
  • The value Search for key Polaris.ActionList.SearchField.search is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
  • The value Search actions for key Polaris.ActionList.SearchField.placeholder is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-needed Added by a bot. Contributor needs to sign the CLA Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant