[ActionList/Item] Fix disabling ActionList Item when url prop is pass…

…ed (#3979)

* Disable ActionList Item when url prop is passed

* Update UNRELEASED.md

* Update to set url and onClick to null + Add tests

UNRELEASED.md

@@ -16,6 +16,7 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f
 - Fixed click propagation that was preventing the `Tooltip` to open when used as suffix on a `TextField` ([#3956](https://github.com/Shopify/polaris-react/issues/3956))
 - Made items in `ActionList` more clear in high contrast mode ([#3971](https://github.com/Shopify/polaris-react/pull/3971))
 - Fixed the MediaCard thumbnail’s corner roundness, so it wouldn’t overflow out of the parent Card ([#3974](https://github.com/Shopify/polaris-react/issues/3974))
+- Fixed `ActionList` `Item` not disabling properly when url prop is passed ([#3979](https://github.com/Shopify/polaris-react/pull/3979))
 
 ### Documentation
 

src/components/ActionList/components/Item/Item.tsx

@@ -94,11 +94,11 @@ export function Item({
   const control = url ? (
     <UnstyledLink
       id={id}
-      url={url}
+      url={disabled ? null : url}
       className={className}
       external={external}
       aria-label={accessibilityLabel}
-      onClick={onAction}
+      onClick={disabled ? null : onAction}
     >
       {contentElement}
     </UnstyledLink>

src/components/ActionList/components/Item/tests/Item.test.tsx

@@ -80,6 +80,20 @@ describe('<Item />', () => {
       mockAccessibilityLabel,
     );
   });
+
+  it('passes `url` as null to `<UnstyledLink />` when disabled', () => {
+    const item = mountWithApp(<Item url="https://shopify.com" disabled />);
+
+    expect(item.find(UnstyledLink)!.prop('url')).toBeNull();
+  });
+
+  it('passes `onClick` as null to `<UnstyledLink />` when disabled', () => {
+    const item = mountWithApp(
+      <Item onAction={noop} disabled url="https://shopify.com" />,
+    );
+
+    expect(item.find(UnstyledLink)!.prop('onClick')).toBeNull();
+  });
 });
 
 function noop() {}