Skip to content

Commit

Permalink
PR review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
chloerice committed Dec 9, 2022
1 parent 2710d40 commit 05e1c72
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .stylelintrc.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/** @type {import('stylelint').Config} */
module.exports = {
extends: [/*'@shopify/stylelint-plugin/prettier', */ './stylelint-polaris'],
extends: ['@shopify/stylelint-plugin/prettier', './stylelint-polaris'],
// Disabling @shopify/stylelint-plugin/configs/core no-unknown-animations as stylelint is not aware of global Polaris keyframes
// TODO: create custom plugin to ensure animation-names match Polaris keyframe names
customSyntax: 'postcss-scss',
Expand Down
4 changes: 2 additions & 2 deletions stylelint-polaris/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ const {
/**
* @type {import('./plugins/coverage').CategorizedRules} The stylelint-polaris/coverage rule expects a 3-dimensional rule config that groups Stylelint rules by coverage categories. It reports problems with dynamic rule names by appending the category to the coverage plugin's rule name
(e.g., Unexpected named color "blue" - Please use a Polaris color token Stylelint(stylelint-polaris/coverage/colors/color-named)")
(e.g., Unexpected named color "blue" - Please use a Polaris color token Stylelint(polaris/colors/color-named)")
*/
const stylelintPolarisCoverageOptions = {
colors: [
{
'color-named': 'never',
'color-no-hex': [true, {message: 'Please use a Polaris color token'}],
'color-no-hex': true,
'scss/function-color-relative': true,
'declaration-property-value-disallowed-list': {
opacity: [/(?!0|1)\d$|^\d{2,}|^[1-9]+\.|^\d+\.\d+\.|^0\.\d{3,}/],
Expand Down

0 comments on commit 05e1c72

Please sign in to comment.