Remove stale mem_info function #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, this is a bit of a left-over from when the reforking heuristic was memory usage based.
We don't we have our own implementation. But I think it doesn't cost much to include it, it's probably useful as a reference on how to correctly measure memory usage. So yeah, I'd keep it. |
This used to be at least occasionally updated in Shopify@aebdc2e, in Shopify@7239fba it got removed The user is required to call refresh themselves in order to not get stale results after first access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to be at least occasionally updated in aebdc2e, in 7239fba it got removed
The user is required to call refresh themselves in order to not get stale results after first access.
Removing
MemInfomay be a overkill? You probably use that at Shopify, I distinctly remember a graph about cow efficiency somewhere. Generally I'm unsure about the level of backwards compatibility you want to guarantee at this time.