Remove START_CTX
#111
Merged
Remove START_CTX
#111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
START_CTX[:cwd] is already completly unused. Like the comment states, we can get rid of it. It was used in conjunction with USR2 to modify a running master into spawning workers with different arguments which is a non-goal for Pitchfork
|
Technically, both But since now it's only used to update the proctitle, I suppose it's fine if it no longer reflect the spawn arguments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
START_CTX[:cwd]is already completly unused.Like the comment states, we can get rid of it. It was used in conjunction with USR2 to modify a running master into spawning workers with different arguments (for a rolling deploy with only one host for example) which is a non-goal for Pitchfork and does in fact not work anymore anyways.
Slight behaviour change: argv was modified to contain the default listener if none was specified which made it appear in the proctitle. This was probably done for other reasons, and I don't see a particular reason why it should continue to do so.