Don't run rubocop in parallel with the Rake task #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirceu
approved these changes
Aug 25, 2021
lawrencewong
pushed a commit
to lawrencewong/maintenance_tasks
that referenced
this pull request
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I run
bundle exec rakethe tests fail, and it has been happening since #470.It comes from rubocop/rubocop#10000.
Parallelization causes issues with the way Rails runs tests see rails/rails#41132, since Rails uses
at_exit, and Rubocop creates multiple forks, all of them start running the tests, and database locking occurs.We could also fix that by moving the Rubocop task first, since the
at_exithooks wouldn't have been defined at this point, but I like to keep it at the end, and it's not that slow anyway. It could also be fixed by Rubocop not running its code directly from the Rake task, but in a subprocess, which would not bring along theat_exithooks.