Remove status transition of paused => cancelling #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RuboCop v1.6.1 has got a bug so CI is failing |
adrianna-chang-shopify
force-pushed
the
remove-invalid-status-transition
branch
from
5723f22
to
b9de606
Compare
etiennebarrie
approved these changes
Jun 10, 2021
lawrencewong
pushed a commit
to lawrencewong/maintenance_tasks
that referenced
this pull request
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This transition was introduced in #166, but I have no idea why 馃槄
With our logic in
Run#cancel:maintenance_tasks/app/models/maintenance_tasks/run.rb
Lines 180 to 185 in 64ad4a5
The only possible transition for a
pausedrun if a user presses "Cancel" is to move it tocancelled.