Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reject filter #1573

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Add reject filter #1573

wants to merge 29 commits into from

Conversation

andershagbard
Copy link
Contributor

This filter adds the inverse of the where filter.

This filter also allows deep searching with dot notation.

Idea from: #1555

andershagbard and others added 25 commits March 30, 2021 12:23
@andershagbard
Add replace_last and remove_last tests
832516f
@andershagbard
Add replace_last and remove_last filters
e575c1f
@andershagbard
Use correct method
7754a0f
@andershagbard
Improve tests
38b7364
@andershagbard
Update tests
effee1e
@andershagbard @ADTC
Update tests
b3d14e5 
Co-Authored-By: ADTC <ADTC@users.noreply.github.com>
@andershagbard
Merge branch 'Shopify:master' into master
973aa9f
@andershagbard
Update History.md
d5ecf00
@andershagbard
Delegate functions to corresponding replace functions
f72cfb1
@andershagbard
Update filter to use rindex
dc7818f
@andershagbard
Update test to support third argument
f5e77b6
@andershagbard
Remove default value for replacement argument
b5abd14
@andershagbard
start_index will never be -1
986391c
@andershagbard
Favor unless over if for negative conditions
e3c82a9
@andershagbard
Add tests to make sure it returns original string on no replacement
d81f7f0
@andershagbard
Refactor filter
aead4c5
@andershagbard
Merge branch 'Shopify:master' into master
f17c497
@andershagbard @dylanahsmith
Update lib/liquid/standardfilters.rb
5187399 
Co-authored-by: Dylan Thacker-Smith <dylan.smith@shopify.com>
@andershagbard
Remove string formatter
45f186b
@andershagbard
Use rindex again
0f17ed0
@dylanahsmith
Merge remote-tracking branch 'origin/master' into pr-1422
873ca15
@dylanahsmith
History.md: Add missing PR number to previous changelog entry
50c88fe
@dylanahsmith
Fix new changelog entry so it is under unreleased
588d407
@dylanahsmith
Remove redundant test assertions
63ae4cc
@andershagbard
Add reject filter
bfdcfce
@andershagbard

This comment was marked as resolved.

Sign in to view
@bakura10
Copy link

I’m not a ruby developer but it seems you also added a nice feature on the reject filter allowing to filter nested objects. This should most likely be backported to the where filter as well.

@andershagbard
Copy link
Contributor Author

I’m not a ruby developer but it seems you also added a nice feature on the reject filter allowing to filter nested objects. This should most likely be backported to the where filter as well.

That has proven a bit harder, as there is some backward compatibility we need to take care of: #1436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luiz-m-affonso luiz-m-affonso luiz-m-affonso left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andershagbard @bakura10 @luiz-m-affonso @dylanahsmith