Fix resource limit scores resetting on include #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
When `include` is used in a template, it'll go through `Liquid::Template#render`, which is called on a new template instance but with the same context. Meaning the "partial" that was included will keep using & updating the same `Liquid::ResourceLimits` instance. Among those updates though, there is an initial, unconditional reset of the scores done inside `Liquid::Template#render`. After this fix, the reset will only be applied if the method was not called inside a partial context.
agon-qurdina
force-pushed
the
agon-fix-resource-scores-reset-on-include
branch
from
2499d7a
to
277a620
Compare
agon-qurdina
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
includeis used in a template, it'll go throughLiquid::Template#render, which is called on a new template instance but with the same context. Meaning the "partial" that was included will keep using & updating the sameLiquid::ResourceLimitsinstance. Among those updates though, there is an initial, unconditional reset of the scores done insideLiquid::Template#render.After this fix, the reset will only be applied if the method was not called inside a partial context.