This repository has been archived by the owner on Jan 30, 2023. It is now read-only.
Add option to return redirect URL as a header in verifyRequest #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
force-pushed
the
return_header_on_verify_request
branch
from
2bf49ac
to
f4e55f9
Compare
mkevinosullivan
approved these changes
Mar 23, 2021
|
Will there be a readme update? |
paulomarg
force-pushed
the
return_header_on_verify_request
branch
from
f4e55f9
to
f2ec2d2
Compare
mkevinosullivan
approved these changes
Mar 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes Shopify/shopify-app-template-node#575
Currently, the
verifyRequestmiddleware will always return the code to redirect the user back to/auth, even if the request is not for a page. In those cases, we still want to fail the request, but we need the frontend to be able to pick up on this and trigger the OAuth flow.WHAT is this pull request doing?
This adds a
returnHeadersetting toverifyRequest, which will fail the request but return the necessary data for a redirect as a header, rather than the actual redirection code. That will allow the middleware to be used for both page loads and XHR requests.Type of change
Checklist