Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds dynamic screen height to Tailwind for Cart Drawer #2102

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

benjaminsehl
Copy link
Member

Description

Today the cart drawer uses svh when supported, as the height. This means that if the user has scrolled, the cart drawer will not fill the page (see screenshot).

image

We still want to keep svh as the main way to interact with h-screen as it's most often used for full bleed Hero banners (and similar) where you don't want the height to change (too jarring). However specifically on the cart drawer, this should be dynamic, as you can only scroll within the pane when it's open.

This also updates @headlessui to 1.7.0 to resolve a bug found in scroll lock: tailwindlabs/headlessui#949

Before submitting the PR, please make sure you do the following:

  • Read the Contributing Guidelines
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
  • Update docs in this repository according to your change
  • Run yarn changeset add if this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning

Copy link
Contributor

@lordofthecactus lordofthecactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ I was reading about dvh. Neat!

@benjaminsehl benjaminsehl merged commit 1d8e2b4 into v1.x-2022-07 Sep 8, 2022
@benjaminsehl benjaminsehl deleted the sehl/dvh-cart-drawer-fix branch September 8, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants