Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Fix bug in storefront client. #125

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Fix bug in storefront client. #125

merged 1 commit into from
Jan 18, 2023

Conversation

frehner
Copy link
Contributor

@frehner frehner commented Jan 18, 2023

Update the nextjs app to reflect that

Fix issue with latest graphql codegen needing ts-node

Add tests


Before submitting the PR, please make sure you do the following:

  • Read the Contributing Guidelines
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
  • Update docs in this repository according to your change
  • Run yarn changeset add if this PR cause a version bump based on Keep a Changelog. If you have a breaking change, it will need to wait until the next major version release. Otherwise, use patch updates even for new features. Read more about Storefront Kit's versioning.

Update the nextjs app to reflect that

Fix issue with latest graphql codegen needing ts-node

Add tests
@@ -19,7 +19,7 @@
"react-dom": "18.2.0"
},
"devDependencies": {
"@graphql-codegen/cli": "2.16.4",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to downgrade to fix a bug. dotansimha/graphql-code-generator#8814

@frehner frehner merged commit 736cc41 into 2023-01 Jan 18, 2023
@frehner frehner deleted the fix-shopify-client branch January 18, 2023 18:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant