Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally the purpose of this was to fix #78 but I wanted to see how far I could simplifying this, removing old compatibility support, and removing unneeded features. This is a draft PR since I'm looking for overall feedback.
This PR does many things, but here's a rough summary:
use
interface which sets up the necessary trace modules and query analyzer with acapture_timings
optionI assume this will lower memory allocations and have better performance too but I haven't done any benchmarks yet. There's a lot less objects and hashes allocated if nothing else.
cc @Shopify/api-patterns-team