Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 release WIP #166

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

v2 release WIP #166

wants to merge 5 commits into from

Conversation

lavoiesl
Copy link
Contributor

@lavoiesl lavoiesl commented Feb 7, 2023 •
edited

In no particular order:

  • Get rid of global state
    • Inject Statsd backend
  • Get rid of the Logger type
    • replace Global Fields -> Global client with fields
  • Convert ContextLog to a logrus hook
  • Extend LoggableError with Fault
  • HTTP errors
    • Have an internal error for debugging purposes, and an external error with a message or status code.
  • compare errors and fault from go-npt and open something similar in goose
  • stats tag for errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@lavoiesl