Update to go 1.17.x #113
Open
Update to go 1.17.x #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavoiesl
reviewed
Dec 7, 2021
| @@ -1,6 +1,6 @@ | |||
| module github.com/Shopify/goose | |||
|
|
|||
| go 1.15 | |||
| go 1.17 | |||
There was a problem hiding this comment.
The version in the go.mod is the minimum version. I'm okay with that, I think go1.17 is a good minimum nowadays, but that means that the testing matrix below 1.17 is not really useful
There was a problem hiding this comment.
I'm not sure there is much value in forcing every Goose users to upgrade to 1.17.
Staying compatible does not cost much, here.
pior
approved these changes
Dec 7, 2021
|
Given that the intention is to make a breaking change with goose and how we structure it, I feel ok with going with 1.17.x as minimum version, especially since we are doing the same with the other libs like go-storage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to go 1.17.x to match what we have with other repos
I kept the testing matrix against the prev 2 versions but I can also drop that if it's not necessary