Support new Rubocop 0.84 interface for correctors #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pftg
force-pushed
the
162-fix-no-method-error-for-rubocop-84
branch
2 times, most recently
from
c540049
to
3cd3840
Compare
Rubocop changed interface and after rubocop/rubocop#7863 it requires correctors to accept nodes. Closes Shopify#162
pftg
force-pushed
the
162-fix-no-method-error-for-rubocop-84
branch
from
3cd3840
to
8beb0f0
Compare
|
Hey, @etiennebarrie @EiNSTeiN- here is another bug fix. Please check when you will have a time |
etiennebarrie
approved these changes
May 25, 2020
|
@etiennebarrie could you guide me, what the next steps we require in order to merge PR in this repo? Thanks for review |
|
@etiennebarrie small nudge 😊 would love to get our erb linter up and running again 🚀 |
|
Sorry and thanks for reminding me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubocop changed interface and after
rubocop/rubocop#7863 it requires correctors
to accept nodes.
Closes #162