Revert Nokogiri refactor #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is just a straight revert, right? I haven鈥檛 checked the code closely, but overall LGTM. I 馃帺 with https://github.com/Shopify/shopify/pull/135318 and it works fine, but the |
|
Yup, content style shouldn't be running. There's no config for it in master: https://github.com/Shopify/shopify/blob/master/config/erb-lint.yml And yes, I created this with |
|
|
nwtn
approved these changes
Oct 25, 2017
EiNSTeiN-
approved these changes
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The attempts to refactor this app to use Nokogiri and implement content style linting were never entirely successful. Rather than reverting at the time (a year ago! 馃槺 ) we just changed Policial to use the last known good revision (
e406c19). But Justin never came back and Nathan Marks (who attempted to fix it) also left. So we're left with an app where HEAD is broken and Policial depends on revision four commits back.Look at discussion in PRs #6, #8, #9, and #10 for additional history.
Solution
As per https://github.com/Shopify/shopify/pull/135318#issuecomment-339423380, let's revert all these changes so that HEAD is the last known good state. I've maintained the original commits in a branch called
nokogiri-refactor.FYI @EiNSTeiN-