feat: ✨ product shipping countdown timer #3324
Conversation
Committed from shop: dawn shipping countdown
![translation-platform[bot]](https://avatars.githubusercontent.com/in/7649?s=60&v=4){kind=small}
| @@ -1955,6 +1955,30 @@ | |||
| "price": { | |||
| "name": "Price" | |||
| }, | |||
| "shipping_countdown": { | |||
| "name": "Shipping countdown", | |||
There was a problem hiding this comment.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Shipping countdownfor keysections.main-product.blocks.shipping_countdown.nameis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
| "name": "Shipping countdown", | ||
| "settings": { | ||
| "message": { | ||
| "label": "Message", |
There was a problem hiding this comment.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Messagefor keysections.main-product.blocks.shipping_countdown.settings.message.labelis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
| "info": "{countdown}: Active countdown timer until time threshold.\n{time}: Show time threshold." | ||
| }, | ||
| "time_threshold": { | ||
| "label": "Time threshold", |
There was a problem hiding this comment.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Time thresholdfor keysections.main-product.blocks.shipping_countdown.settings.time_threshold.labelis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
|
I already signed the CLA, signing again causes an error because that github username has already signed it. |
PR Summary:
Adds a widget to display a same day shipping countdown on product pages
Why are these changes introduced?
What approach did you take?
Other considerations
Decision log
Visual impact on existing themes
Testing steps/scenarios
Demo links
dawnChecklist