Downgrade oclif and typescript #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrading oclif introduced bugs with boolean flags. Need to downgrade again until oclif/core#536 is merged to oclif.
|
We detected some changes at packages/*/src and there are no updates in the .changeset. |
jplhomer
approved these changes
Oct 24, 2022
shauns
reviewed
Oct 24, 2022
packages/cli-main/package.json
Outdated
| @@ -51,7 +51,7 @@ | |||
| ] | |||
| }, | |||
| "dependencies": { | |||
| "@oclif/core": "1.16.4", | |||
| "@oclif/core": "1.9.2", | |||
| "@oclif/plugin-commands": "^2.2.0", | |||
| "@oclif/plugin-help": "^5.1.14", | |||
There was a problem hiding this comment.
these two should also be nudged back:
There was a problem hiding this comment.
@shauns excellent point, I've updated those as well.
pepicrft
approved these changes
Oct 24, 2022
6 tasks
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Upgrading oclif introduced bugs with boolean flags. Need to downgrade again until oclif/core#536 is merged to oclif.
This is an alternative approach vs #662
WHAT is this pull request doing?
Downgrades oclif and typescript, essentially reverting #555 (but with some extra work because the
base-commandcode has changes)How to test your changes?
Run the CLI...
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.