Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Temporarily disable env var arguments for boolean default-true/exclusive flags #662

Closed
wants to merge 1 commit into from
Closed

Fix: Temporarily disable env var arguments for boolean default-true/exclusive flags #662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/app/src/cli/commands/app/dev.ts
View file
Open in desktop
Expand Up @@ -58,17 +58,19 @@ export default class Dev extends Command {
env: 'SHOPIFY_FLAG_TUNNEL_URL',
exclusive: ['no-tunnel', 'tunnel'],
}),
// eslint-disable-next-line rulesdir/command-flags-with-env
'no-tunnel': Flags.boolean({
hidden: true,
description: 'Automatic creation of a tunnel is disabled. Service entry point will listen to localhost instead',
env: 'SHOPIFY_FLAG_NO_TUNNEL',
// env: 'SHOPIFY_FLAG_NO_TUNNEL',
default: false,
exclusive: ['tunnel-url', 'tunnel'],
}),
// eslint-disable-next-line rulesdir/command-flags-with-env
tunnel: Flags.boolean({
hidden: false,
description: 'Use ngrok to create a tunnel to your service entry point',
env: 'SHOPIFY_FLAG_TUNNEL',
// env: 'SHOPIFY_FLAG_TUNNEL',
default: true,
exclusive: ['tunnel-url', 'no-tunnel'],
}),
Expand Down
3 changes: 2 additions & 1 deletion packages/cli-hydrogen/src/cli/commands/hydrogen/build.ts
View file
Open in desktop
Expand Up @@ -18,9 +18,10 @@ export default class Build extends Command {
description: ' the public path when served in production',
env: 'SHOPIFY_FLAG_BUILD_BASE',
}),
// eslint-disable-next-line rulesdir/command-flags-with-env
client: Flags.boolean({
description: 'build the client code',
env: 'SHOPIFY_FLAG_BUILD_CLIENT',
// env: 'SHOPIFY_FLAG_BUILD_CLIENT',
allowNo: true,
default: true,
}),
Expand Down
3 changes: 2 additions & 1 deletion packages/cli-hydrogen/src/cli/commands/hydrogen/deploy.ts
View file
Open in desktop
Expand Up @@ -29,8 +29,9 @@ export default class Deploy extends Command {
env: 'SHOPIFY_HYDROGEN_FLAG_PATH_TO_BUILD',
description: 'Skip build process and use provided value as build',
}),
// eslint-disable-next-line rulesdir/command-flags-with-env
healthCheck: Flags.boolean({
env: 'SHOPIFY_HYDROGEN_FLAG_HEALTH_CHECK',
// env: 'SHOPIFY_HYDROGEN_FLAG_HEALTH_CHECK',
default: true,
description: 'Require a health check before the deployment succeeds.',
}),
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-hydrogen/src/cli/flags.ts
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@ export const hydrogenFlags = {
hidden: true,
default: true,
description: 'should install packages',
env: 'SHOPIFY_HYDROGEN_FLAG_INSTALL',
// env: 'SHOPIFY_HYDROGEN_FLAG_INSTALL',
allowNo: true,
}),
}