New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont revalidate on windows #472

Draft

casperisfine wants to merge 1 commit into main from dont-revalidate-on-windows

Contributor

casperisfine commented Jan 30, 2024

Hoping to fix:

 1) Failure:
CompileCacheHandlerErrorsTest#test_input_to_output_unexpected_type [test/compile_cache_handler_errors_test.rb:61]:
not all expectations were satisfied
unsatisfied expectations:
- expected exactly once, invoked never: Bootsnap::CompileCache::ISeq.input_to_output(any_parameters)
- expected exactly once, invoked never: Bootsnap::CompileCache::ISeq.input_to_storage(any_parameters)

To be fair that test is a bit weird, but I don't really have much ways to debug windows anyway.


          Don't attempt to update cache entries on Windows.

20a8956

casperisfine force-pushed the dont-revalidate-on-windows branch from 6ff60c6 to 20a8956 Compare

January 30, 2024 17:03

Contributor Author

casperisfine commented Jan 30, 2024

Hum, retrying the failed build worked, so maybe it was a fluke of some sort? I'll keep this as a draft for now.

casperisfine marked this pull request as draft

January 30, 2024 17:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment