Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set encoding for write pipe #364

Merged
merged 2 commits into from Jul 26, 2021
Merged

Set encoding for write pipe #364

merged 2 commits into from Jul 26, 2021

Commits on Jul 26, 2021

  1. Set encoding for write pipe 

    This fixes the `Encoding::UndefinedConversionError` error for Rails
applications. Rails sets the default encoding to UTF8:
https://github.com/rails/rails/blob/main/railties/lib/rails.rb#L22-L23

We want to set it to Binary but the IO.pipe method only sets it for the
reader, not the writer.
    @ngan
    ngan committed Jul 26, 2021
    Copy the full SHA
    d705a40 View commit details
    Browse the repository at this point in the history

  2. Update changelog

    @ngan
    ngan committed Jul 26, 2021
    Copy the full SHA
    c6ecffc View commit details
    Browse the repository at this point in the history