Reduce allocations by freezing paths #311
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base on #310 for CI purposes.
This patch is based on an implementation detail of MRI. Pretty much all
File
methods callFilePathStringValue()
on the passed path. This method will always dup the string unless it's already frozen. As a result freezing paths before calling `File methods will save one string allocation the vast majority of the time.Of course it only really matter it loops, but Bootsnap have a few of these.