Merge pull request #478 from Earlopain/store-with-broken-symlink

Fix startup failure if the cache directory points to a broken symlink

CHANGELOG.md

@@ -1,5 +1,7 @@
 # Unreleased
 
+* Fix startup failure if the cache directory points to a broken symlink.
+
 # 1.18.3
 
 * Fix the cache corruption issue in the revalidation feature. See #474.

lib/bootsnap/load_path_cache/store.rb

@@ -122,6 +122,8 @@ def mkdir_p(path)
         stack.reverse_each do |dir|
           Dir.mkdir(dir)
         rescue SystemCallError
+          # Check for broken symlinks. Calling File.realpath will raise Errno::ENOENT if that is the case
+          File.realpath(dir) if File.symlink?(dir)
           raise unless File.directory?(dir)
         end
       end

test/load_path_cache/store_test.rb

@@ -85,6 +85,13 @@ def test_retry_on_collision
         store.transaction { store.set("a", 1) }
       end
 
+      def test_with_broken_symlink
+        FileUtils.ln_s(@path, "#{@dir}/store_broken")
+        store = Store.new("#{@dir}/store_broken/store")
+
+        store.transaction { store.set("a", "b") }
+      end
+
       def test_ignore_read_only_filesystem
         MessagePack.expects(:dump).raises(Errno::EROFS.new("Read-only file system @ rb_sysopen"))
         store.transaction { store.set("a", 1) }