Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh render issue #1

Merged
merged 5 commits into from
Dec 13, 2018
Merged

zsh render issue #1

merged 5 commits into from
Dec 13, 2018

Conversation

valarauca
Copy link

Summery

We switch from the mpb to pb progress bar library. This fix was coupled with an implicit fix for windows render issues.

The root of the error as far as I can tell is broken zsh configurations. Sadly mpb uses 3 escape sequences to do what pb does with 1. This extra escape sequence allows for it to terminate existing escape sequences which could potentially be opened to be a bad configuration. One should be able to quick see iTerm2 + zsh + oh-my-zsh has had rough transition in MacOS Mojave as it appears some of the configuration options in zsh were very quietly broken in the transition.

Either way, backwards compatibility, and cross platform support is king so here we are.

Motivation

Changes

Test

I'll need assistance with this if I could ask for these folks for assistance to see if this works

  • @tuxology can I borrow Josh to do windows testing? If we could get screen shots of
    • powershell.exe
    • cmd.exe
    • gitbash.exe
    • cygwin
  • @Preetam can you test with zsh and bash in the vanilla Terminal.app in MacOS?
  • @perrito666 / @prathik23 can either you attempt to duplicate your issue in MacOS?
  • @tuxology can you be a control for linux-centric zsh ?

@Preetam
Copy link

Preetam commented Dec 13, 2018

Works for me

@valarauca
Copy link
Author

well we gained support for cygwin and mtty, but alas oh-my-zsh users are still broken.

@valarauca
Copy link
Author

screenshot from 2018-12-13 09-48-59

success_kid

Finishing up a feature request for @perrito666 that we should pad a few new lines prior to starting to display the progress bar. This is now exposed as a configuration operation, so if PadStart string is included it'll print that before the bar is rendered.

@valarauca valarauca merged commit 9678b0e into master Dec 13, 2018
@valarauca valarauca deleted the cody/zsh_render_issue branch December 13, 2018 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants