Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summery
We switch from the
mpb
topb
progress bar library. This fix was coupled with an implicit fix for windows render issues.The root of the error as far as I can tell is broken
zsh
configurations. Sadlympb
uses 3 escape sequences to do whatpb
does with 1. This extra escape sequence allows for it to terminate existing escape sequences which could potentially be opened to be a bad configuration. One should be able to quick seeiTerm2
+zsh
+oh-my-zsh
has had rough transition in MacOS Mojave as it appears some of the configuration options inzsh
were very quietly broken in the transition.Either way, backwards compatibility, and cross platform support is king so here we are.
Motivation
Changes
config.go
who's goal is mostly runfunc init()
and set a few variblespb_win.go
to possibly offer support onmintty
,cygwin
,gitbash.exe
doesn't work for mintty on windows cheggaaa/pb#88Test
I'll need assistance with this if I could ask for these folks for assistance to see if this works
powershell.exe
cmd.exe
gitbash.exe
cygwin
zsh
andbash
in the vanillaTerminal.app
in MacOS?zsh
?