Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(lint): upgrade trunk #24

Merged
merged 1 commit into from Apr 5, 2023
Merged

Conversation

Serpentiel
Copy link
Owner

About this change—what it does?

upgrades trunk, also does some various fixes related to linters, especially we stop forcing Go version in golangci-lint.yml as golangci/golangci-lint#2649 was resolved

What type of change is it?

  • New feature, i.e. non-breaking change which adds functionality

  • This change requires a documentation update

Have you checked yourself twice?

  • Any dependent changes have been merged and published in downstream modules
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • My code follows the contributing guidelines of this project

@Serpentiel Serpentiel added enhancement New feature or request auto approve Automatically approves the PR labels Apr 5, 2023
@Serpentiel Serpentiel self-assigned this Apr 5, 2023
@Serpentiel Serpentiel merged commit ddccc39 into main Apr 5, 2023
18 of 19 checks passed
@Serpentiel Serpentiel deleted the serpentiel-ci-lint-upgrade-trunk branch April 5, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto approve Automatically approves the PR enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant