Merge pull request #228 from dvandersluis/redundant-merge-unsafe

Mark `Performance/RedundantMerge` as unsafe
SerhiiMisiura · Mar 29, 2021 · f8f72b5 · f8f72b5
2 parents 3984bc3 + 8d0827a
commit f8f72b5
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## master (unreleased)
 
+### Changes
+
+* [#228](https://github.com/rubocop/rubocop-performance/pull/228): Mark `Performance/RedundantMerge` as unsafe. ([@dvandersluis][])
+
 ## 1.10.2 (2021-03-23)
 
 ### Bug fixes

diff --git a/config/default.yml b/config/default.yml
@@ -220,7 +220,9 @@ Performance/RedundantMerge:
   Description: 'Use Hash#[]=, rather than Hash#merge! with a single key-value pair.'
   Reference: 'https://github.com/JuanitoFatas/fast-ruby#hashmerge-vs-hash-code'
   Enabled: true
+  Safe: false
   VersionAdded: '0.36'
+  VersionChanged: '1.11'
   # Max number of key-value pairs to consider an offense
   MaxKeyValuePairs: 2
 

diff --git a/docs/modules/ROOT/pages/cops_performance.adoc b/docs/modules/ROOT/pages/cops_performance.adoc
@@ -1272,17 +1272,20 @@ return value unless regex =~ 'str'
 | Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
 
 | Enabled
-| Yes
-| Yes
+| No
+| Yes (Unsafe)
 | 0.36
-| -
+| 1.11
 |===
 
 This cop identifies places where `Hash#merge!` can be replaced by
 `Hash#[]=`.
 You can set the maximum number of key-value pairs to consider
 an offense with `MaxKeyValuePairs`.
 
+This cop is marked as unsafe because RuboCop cannot determine if the
+receiver of `merge!` is actually a hash or not.
+
 === Examples
 
 [source,ruby]

diff --git a/lib/rubocop/cop/performance/redundant_merge.rb b/lib/rubocop/cop/performance/redundant_merge.rb
@@ -8,6 +8,9 @@ module Performance
       # You can set the maximum number of key-value pairs to consider
       # an offense with `MaxKeyValuePairs`.
       #
+      # This cop is marked as unsafe because RuboCop cannot determine if the
+      # receiver of `merge!` is actually a hash or not.
+      #
       # @example
       #   # bad
       #   hash.merge!(a: 1)