Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix chrome version not found #632

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apmechev
Copy link

Raises with a useful message when the Chrome version is not found

@pep8speaks
Copy link

pep8speaks commented Sep 30, 2023

Hello @apmechev! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 62:80: E501 line too long (109 > 79 characters)

Comment last updated at 2023-09-30 16:29:14 UTC

Raises with a useful message when the Chrome version is not found
Copy link

@rf-santos rf-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a check for the < 113 version. Otherwise, if determined_browser_version is set to None (e.g. Chrome not installed - also found no exception for this) it will raise an unhelpfull error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants