LibJS: Add missing MUST in DisposableStack.prototype.use #17161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although the spec has a TRY here I believe this is a spec issue together with the missing TRY just above this change.
github-actions
bot
added
the
👀 pr-needs-review
|
Ref #17162 |
linusg
approved these changes
Jan 24, 2023
github-actions
bot
removed
the
👀 pr-needs-review
|
add_disposible |
It could yes, do we need to do something different in such cases? |
|
I think we have TRY_OR_OOM, I remember that there was talk about the spec not being OOM aware and us fixing some places to be so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the spec has a TRY here I believe this is a spec issue together with the missing TRY just above this change.
See tc39/proposal-explicit-resource-management#142