Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency upgrade June #1358

Merged
merged 8 commits into from Jun 29, 2021
Merged

Conversation

enikonemeth
Copy link
Contributor

@enikonemeth enikonemeth commented Jun 15, 2021

date-io is skipped as usual (material-ui date picker only work with the currently installed version)

react and react-dom cannot be updated to 17.x yet, we are waiting for http://github.com/enzymejs/enzyme/issues/2429 this issue. related PR: http://github.com/enzymejs/enzyme/pull/2430

webpack and ts-loader is not upgradable on sn-react-component-docs (storybook). No stable release currently support webpack 5.

Fast refresh of example apps (FAST_REFRESH env variable) has been turned off. (yarn start throws error otherwise for unknown reason)

cannot update to typescript 4.3.x cause this: storybookjs/storybook#15067
we should wait for a new storybook version

CHANGES

because of monaco-editor-webpack-plugin:
webpack.common.js
inlineHints -> inlayHints
plus '!inlineCompletions'

because of type error:
RichTextEditor.tsx

dangerouslySetInnerHTML={{
                __html: typeof props.fieldValue === 'string' ? props.fieldValue : props.fieldValue.text,
              }}
			  
		  -->
			  dangerouslySetInnerHTML={{
                __html: typeof props.fieldValue === 'string' ? props.fieldValue : (props.fieldValue as any).text,
              }}
			

we had warnings like:
Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-property-in-object since the "loose" mode option was set to "true" for @babel/plugin-proposal-private-methods.
The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
["@babel/plugin-proposal-private-property-in-object", { "loose": true }]
to the "plugins" section of your Babel config.

rails/webpacker#3008

'@babel/plugin-proposal-class-properties' --> ['@babel/plugin-proposal-class-properties', { loose: true }]

because of jest breaking changes:
https://jestjs.io/blog/2021/05/25/jest-27

  • install ts-jest, @types/jest to root
  • testEnvironment: 'jsdom', testRunner: 'jest-jasmine2' to base-config
  • import { setImmediate } from 'timers' where we use

@enikonemeth enikonemeth self-assigned this Jun 15, 2021
@CLAassistant
Copy link

CLAassistant commented Jun 15, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ herflis
✅ taki9
✅ pusztaienike
❌ pusztaie


pusztaie seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sensenet
Copy link

sensenet bot commented Jun 15, 2021

Site name Url Last deploy
sn-react-component-docs-dev https://60db1d6bb7a1f1cf696c8451--sn-react-component-docs-dev.netlify.app Tue Jun 29 2021 - 13:17:32 GMT+0000 (Coordinated Universal Time)
sn-app-dev https://60db1da5b7a1f1c8006c8a98--sn-app-dev.netlify.app Tue Jun 29 2021 - 13:18:31 GMT+0000 (Coordinated Universal Time)

@SenseNet SenseNet deleted a comment from gatsby-cloud bot Jun 15, 2021
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #1358 (b8cf0c6) into develop (f042f93) will increase coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1358   +/-   ##
========================================
  Coverage    93.17%   93.17%           
========================================
  Files          232      232           
  Lines         6443     6444    +1     
  Branches      1731     1731           
========================================
+ Hits          6003     6004    +1     
  Misses         440      440           
Impacted Files Coverage Δ
...trols-react/src/fieldcontrols/rich-text-editor.tsx 87.17% <75.00%> (+0.33%) ⬆️
...ges/sn-hooks-react/src/context/current-content.tsx 86.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f042f93...b8cf0c6. Read the comment docs.

@taki9 taki9 requested review from taki9 and herflis June 17, 2021 14:44
@enikonemeth enikonemeth merged commit f9d5476 into develop Jun 29, 2021
@enikonemeth enikonemeth deleted the feature/dependency_upgrade_june branch June 29, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants