Revert "Upgrade ESLint and eslint-related plugins to the lastest vers… #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humphd
previously approved these changes
Oct 28, 2021
humphd
added
area: CI/CD
|
Should we only revert |
|
@manekenpix it make sense to me? You want me to revert only eslint ? |
|
Try it and see I guess. |
|
@manekenpix It is up and running, hope it not breaking this time |
|
@BeAmazedVariable I get this error now. While resolving: @senecacdot/telescope@2.2.0
#9 13.23 npm ERR! Found: eslint@7.23.0
#9 13.23 npm ERR! node_modules/eslint
#9 13.23 npm ERR! dev eslint@"7.23.0" from the root project
#9 13.23 npm ERR!
#9 13.23 npm ERR! Could not resolve dependency:
#9 13.23 npm ERR! peer eslint@">=7.28.0" from eslint-plugin-prettier@4.0.0
#9 13.23 npm ERR! node_modules/eslint-plugin-prettier
#9 13.23 npm ERR! dev eslint-plugin-prettier@"4.0.0" from the root projectI guess we can just go with the original idea, reverting the commit, and we'll gradually upgrade the rest of the packages in future PRs. Thanks for making these changes, it was worth trying. |
|
@BeAmazedVariable can we please get this in soon, I want to wrap this up. |
|
@humphd I will be able to jump on around 10 today after work |
…ion" This reverts commit 3d7a333.
|
@manekenpix @humphd sorry for the delay please kindly revierw my recent pull request |
manekenpix
approved these changes
Oct 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
Type of Change
Description
This reverts commit 3d7a333. Related to #2407 where ESLint 8.x broke
staggingserverChecklist