Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency rubocop to v1.63.5 #1712

Merged
merged 2 commits into from May 15, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 9, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rubocop (source, changelog) 1.63.4 -> 1.63.5 age adoption passing confidence

Release Notes

rubocop/rubocop (rubocop)

v1.63.5

Compare Source

Bug fixes
  • #​12877: Fix an infinite loop error for Layout/FirstArgumentIndentation when specifying EnforcedStyle: with_fixed_indentation of Layout/ArrayAlignment. ([@​koic][])
  • #​12873: Fix an error for Metrics/BlockLength when the CountAsOne config is invalid. ([@​koic][])
  • #​12881: Fix incorrect autocorrect when Style/NumericPredicate is used with negations. ([@​fatkodima][])
  • #​12882: Fix Layout/CommentIndentation for comment-only pattern matching. ([@​nekketsuuu][])

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link

netlify bot commented May 9, 2024

Deploy Preview for selenium-dev ready!

Name Link
🔨 Latest commit e202b14
🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/66439b1d1d7d710008699b72
😎 Deploy Preview https://deploy-preview-1712--selenium-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor Author

renovate bot commented May 14, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link

CI Failure Feedback 🧐

Action: test_examples (windows-latest, nightly)

Failed stage: Run tests [❌]

Failure summary:

The action failed due to multiple test failures in the RSpec test suite for a Ruby project. The key
issues include:

  • A test in ./spec/actions_api/mouse_spec.rb failed because the expected mouse coordinates did not
    match the actual coordinates.
  • Several tests in ./spec/drivers/remote_webdriver_spec.rb failed due to a type error where a string
    was expected to be an integer, and another test failed because the expected list of downloadable
    files was not empty.

  • Relevant error logs:
    1:  ##[group]Operating System
    2:  Microsoft Windows Server 2022
    ...
    
    368:  timeout_minutes: 20
    369:  max_attempts: 3
    370:  command: cd examples/ruby
    371:  bundle exec rspec
    372:  
    373:  retry_wait_seconds: 10
    374:  polling_interval_seconds: 1
    375:  warning_on_retry: true
    376:  continue_on_error: false
    ...
    
    411:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-support-3.13.0/lib/rspec/support/source.rb:73:in `select'
    412:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-support-3.13.0/lib/rspec/support/source.rb:73:in `nodes_by_line_number'
    413:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:118:in `location_nodes_at_beginning_line'
    414:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:96:in `expression_node'
    415:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:88:in `line_range_of_location_nodes_in_expression'
    416:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:57:in `line_range_of_expression'
    417:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:42:in `expression_lines'
    418:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:31:in `extract_expression_lines_at'
    419:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/exception_presenter.rb:248:in `read_failed_lines'
    420:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/exception_presenter.rb:171:in `failure_slash_error_lines'
    421:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/exception_presenter.rb:158:in `block in failure_lines'
    ...
    
    443:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/runner.rb:71:in `run'
    444:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/runner.rb:45:in `invoke'
    445:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/exe/rspec:4:in `<top (required)>'
    446:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/bin/rspec:25:in `load'
    447:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/bin/rspec:25:in `<main>'
    448:  Pending: (Failures listed here are expected and do not affect your suite's status)
    449:  1) Keys copy and paste
    450:  # Test guarded; https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264
    451:  Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!'
    452:  expected: "SeleniumSelenium!"
    453:  got: "!"
    454:  (compared using ==)
    455:  # ./spec/actions_api/keys_spec.rb:76:in `block (2 levels) in <top (required)>'
    456:  2) Chrome DevTools waits for downloads
    457:  # Test guarded; no reason given
    458:  Failure/Error: expect { Selenium::WebDriver::Wait.new.until { @completed } }.not_to raise_exception
    459:  expected no Exception, got #<Selenium::WebDriver::Error::TimeoutError: timed out after 5 seconds> with backtrace:
    ...
    
    517:  21) Chrome Driver Options sets remote capabilities
    518:  # this is example code that will not execute
    519:  # ./spec/drivers/options_spec.rb:37
    520:  22) Chrome Driver Options sets capabilities in the pre-selenium 4 way
    521:  # this is example code that will not execute
    522:  # ./spec/drivers/options_spec.rb:122
    523:  Failures:
    524:  1) Mouse move by offset offset from viewport
    525:  Failure/Error: expect(x_coord).to be_within(1).of(8)
    526:  expected 494 to be within 1 of 8
    527:  # ./spec/actions_api/mouse_spec.rb:119:in `block (3 levels) in <top (required)>'
    528:  Finished in 8 minutes 37 seconds (files took 37.65 seconds to load)
    529:  143 examples, 1 failure, 22 pending
    530:  Failed examples:
    531:  rspec ./spec/actions_api/mouse_spec.rb:111 # Mouse move by offset offset from viewport
    532:  ##[warning]Attempt 1 failed. Reason: Child_process exited with error code 1
    ...
    
    596:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-support-3.13.0/lib/rspec/support/source.rb:73:in `select'
    597:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-support-3.13.0/lib/rspec/support/source.rb:73:in `nodes_by_line_number'
    598:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:118:in `location_nodes_at_beginning_line'
    599:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:96:in `expression_node'
    600:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:88:in `line_range_of_location_nodes_in_expression'
    601:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:57:in `line_range_of_expression'
    602:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:42:in `expression_lines'
    603:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:31:in `extract_expression_lines_at'
    604:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/exception_presenter.rb:248:in `read_failed_lines'
    605:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/exception_presenter.rb:171:in `failure_slash_error_lines'
    606:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/exception_presenter.rb:158:in `block in failure_lines'
    ...
    
    628:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/runner.rb:71:in `run'
    629:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/runner.rb:45:in `invoke'
    630:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/exe/rspec:4:in `<top (required)>'
    631:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/bin/rspec:25:in `load'
    632:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/bin/rspec:25:in `<main>'
    633:  Pending: (Failures listed here are expected and do not affect your suite's status)
    634:  1) Keys copy and paste
    635:  # Test guarded; https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264
    636:  Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!'
    637:  expected: "SeleniumSelenium!"
    638:  got: "!"
    639:  (compared using ==)
    640:  # ./spec/actions_api/keys_spec.rb:76:in `block (2 levels) in <top (required)>'
    641:  2) Chrome DevTools waits for downloads
    642:  # Test guarded; no reason given
    643:  Failure/Error: expect { Selenium::WebDriver::Wait.new.until { @completed } }.not_to raise_exception
    644:  expected no Exception, got #<Selenium::WebDriver::Error::TimeoutError: timed out after 5 seconds> with backtrace:
    ...
    
    702:  21) Chrome Driver Options sets remote capabilities
    703:  # this is example code that will not execute
    704:  # ./spec/drivers/options_spec.rb:37
    705:  22) Chrome Driver Options sets capabilities in the pre-selenium 4 way
    706:  # this is example code that will not execute
    707:  # ./spec/drivers/options_spec.rb:122
    708:  Failures:
    709:  1) Remote WebDriver starts remotely
    710:  Got 0 failures and 2 other errors:
    711:  1.1) Failure/Error:
    712:  Selenium::Server.get(:latest,
    713:  background: true,
    714:  args: %w[--selenium-manager true --enable-managed-downloads true])
    715:  TypeError:
    716:  no implicit conversion of String into Integer
    717:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    718:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    719:  1.2) Failure/Error:
    720:  Selenium::Server.get(:latest,
    721:  background: true,
    722:  args: %w[--selenium-manager true --enable-managed-downloads true])
    723:  TypeError:
    724:  no implicit conversion of String into Integer
    725:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    726:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    727:  2) Remote WebDriver uploads
    728:  Got 0 failures and 2 other errors:
    729:  2.1) Failure/Error:
    730:  Selenium::Server.get(:latest,
    731:  background: true,
    732:  args: %w[--selenium-manager true --enable-managed-downloads true])
    733:  TypeError:
    734:  no implicit conversion of String into Integer
    735:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    736:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    737:  2.2) Failure/Error:
    738:  Selenium::Server.get(:latest,
    739:  background: true,
    740:  args: %w[--selenium-manager true --enable-managed-downloads true])
    741:  TypeError:
    742:  no implicit conversion of String into Integer
    743:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    744:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    745:  3) Remote WebDriver downloads
    746:  Got 0 failures and 2 other errors:
    747:  3.1) Failure/Error:
    748:  Selenium::Server.get(:latest,
    749:  background: true,
    750:  args: %w[--selenium-manager true --enable-managed-downloads true])
    751:  TypeError:
    752:  no implicit conversion of String into Integer
    753:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    754:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    755:  3.2) Failure/Error:
    756:  Selenium::Server.get(:latest,
    757:  background: true,
    758:  args: %w[--selenium-manager true --enable-managed-downloads true])
    759:  TypeError:
    760:  no implicit conversion of String into Integer
    761:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    762:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    763:  Finished in 6 minutes 23 seconds (files took 2.89 seconds to load)
    764:  143 examples, 3 failures, 22 pending
    765:  Failed examples:
    766:  rspec ./spec/drivers/remote_webdriver_spec.rb:19 # Remote WebDriver starts remotely
    767:  rspec ./spec/drivers/remote_webdriver_spec.rb:26 # Remote WebDriver uploads
    768:  rspec ./spec/drivers/remote_webdriver_spec.rb:42 # Remote WebDriver downloads
    769:  ##[warning]Attempt 2 failed. Reason: Child_process exited with error code 1
    ...
    
    778:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-support-3.13.0/lib/rspec/support/source.rb:57:in `ast'
    779:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-support-3.13.0/lib/rspec/support/source.rb:73:in `nodes_by_line_number'
    780:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:118:in `location_nodes_at_beginning_line'
    781:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:96:in `expression_node'
    782:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:88:in `line_range_of_location_nodes_in_expression'
    783:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:57:in `line_range_of_expression'
    784:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:42:in `expression_lines'
    785:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:31:in `extract_expression_lines_at'
    786:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/exception_presenter.rb:248:in `read_failed_lines'
    787:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/exception_presenter.rb:171:in `failure_slash_error_lines'
    788:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/exception_presenter.rb:158:in `block in failure_lines'
    ...
    
    810:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/runner.rb:71:in `run'
    811:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/runner.rb:45:in `invoke'
    812:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/exe/rspec:4:in `<top (required)>'
    813:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/bin/rspec:25:in `load'
    814:  from C:/hostedtoolcache/windows/Ruby/3.3.1/x64/bin/rspec:25:in `<main>'
    815:  Pending: (Failures listed here are expected and do not affect your suite's status)
    816:  1) Keys copy and paste
    817:  # Test guarded; https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264
    818:  Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!'
    819:  expected: "SeleniumSelenium!"
    820:  got: "!"
    821:  (compared using ==)
    822:  # ./spec/actions_api/keys_spec.rb:76:in `block (2 levels) in <top (required)>'
    823:  2) Chrome DevTools waits for downloads
    824:  # Test guarded; no reason given
    825:  Failure/Error: expect { Selenium::WebDriver::Wait.new.until { @completed } }.not_to raise_exception
    826:  expected no Exception, got #<Selenium::WebDriver::Error::TimeoutError: timed out after 5 seconds> with backtrace:
    ...
    
    884:  21) Chrome Driver Options sets remote capabilities
    885:  # this is example code that will not execute
    886:  # ./spec/drivers/options_spec.rb:37
    887:  22) Chrome Driver Options sets capabilities in the pre-selenium 4 way
    888:  # this is example code that will not execute
    889:  # ./spec/drivers/options_spec.rb:122
    890:  Failures:
    891:  1) Remote WebDriver downloads
    892:  Failure/Error: expect(driver.downloadable_files).to be_empty
    893:  expected `["file_2.jpg"].empty?` to be truthy, got false
    894:  # ./spec/drivers/remote_webdriver_spec.rb:64:in `block (2 levels) in <top (required)>'
    895:  Finished in 7 minutes 2 seconds (files took 2.98 seconds to load)
    896:  143 examples, 1 failure, 22 pending
    897:  Failed examples:
    898:  rspec ./spec/drivers/remote_webdriver_spec.rb:42 # Remote WebDriver downloads
    899:  ##[error]Final attempt failed. Child_process exited with error code 1
    

    ✨ CI feedback usage guide:

    The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
    The tool analyzes the failed checks and provides several feedbacks:

    • Failed stage
    • Failed test name
    • Failure summary
    • Relevant error logs

    In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

    /checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"
    

    where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

    Configuration options

    • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
    • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
    • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
    • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
    • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

    See more information about the checks tool in the docs.

    @diemol diemol merged commit 326c211 into trunk May 15, 2024
    12 checks passed
    @diemol diemol deleted the renovate/rubocop-1.x-lockfile branch May 15, 2024 03:17
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    2 participants