Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update waits.zh-cn.md translate to chinese #1561

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

Laurel-rao
Copy link

@Laurel-rao Laurel-rao commented Jan 18, 2024

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

Copy link

netlify bot commented Jan 18, 2024

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 671e9cf

@CLAassistant
Copy link

CLAassistant commented Jan 18, 2024

CLA assistant check
All committers have signed the CLA.

@diemol diemol requested a review from alaahong January 19, 2024 09:35
Copy link
Member

@alaahong alaahong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your commits, do we have the possible to update the content as comments?

Solving our example with an implicit wait looks like this:
浏览器自动处理最大的挑战可能是确保网页在某个确定的、期望的状态下执行 Selenium 命令。
这些过程通常处于 混乱竞争状态, 有时候网页先处理好,有时候 Selenium 命令先执行。
这就是为什么需要稳定性测试。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep the original style on flaky tests?


所有导航命令都需要一个准确的 `Ready状态` 值, 这取决于 [网页加载策略]({{< ref "drivers/options#pageloadstrategy" >}}) (一个默认的完成值),之后`浏览器 Driver`将控制权交回给代码进行处理。
这个 `Ready状态` 只关心在html 中定义的 css js 是否被加载,但 js 加载通常导致网页资源的变动,执行下一个 Selenium 命令时,网页元素在交互后可能还没有出现在网页中,。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assets are not only including css and js, it might be more generally treating as resources.
refer: https://www.selenium.dev/documentation/webdriver/drivers/options/#pageloadstrategy

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what should i do. replace "drivers/options#pageloadstrategy" to "https://www.selenium.dev/documentation/webdriver/drivers/options/#pageloadstrategy" ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Just mention that you translated the "assets" as "css js" , but actually, that's not meaning of them only...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants