Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_waits.py add example test_explicity_expected_conditions #1531

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

snowlts
Copy link

@snowlts snowlts commented Nov 17, 2023

add testcase test_explicity_expected_conditions for /examples/python/tests/waits
/test_waits.py

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

add a python example for explicity_wait using expected_conditions;

Motivation and Context

I found that there is no example for explicity_wait using expected_conditions.
so I add it, maybe it will be useful for someone who want to know how to use it

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

add testcase for /examples/python/tests/waits
/test_waits.py

test_explicity_expected_conditions
Copy link

netlify bot commented Nov 17, 2023

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4a260d2

@CLAassistant
Copy link

CLAassistant commented Nov 17, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@titusfortner titusfortner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm biased. I don't think anyone should ever use the expected conditions classes when they can use lambdas.

So my preferences is for examples of expected conditions to go into the support section not the waits section.

Regardless, by adding an import at the top, the line references to this file will all need to be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants