Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Chinese) Show Python example for setting Virtual Authenticator Options #1409

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

BlazerYoo
Copy link
Contributor

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Show the Python code example on the documentation website.

Motivation and Context

Clarifies documentation.

Types of changes

  • Change to the site
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

@netlify
Copy link

netlify bot commented Jun 20, 2023

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 680c280

@alaahong
Copy link
Member

Hi,
@SinghHrmn Seems this committer refer your code for example, is that right place?

@@ -31,7 +31,7 @@ Web 应用程序可以启用基于公钥的身份验证机制(称为 Web 身
{{< badge-code >}}
{{< /tab >}}
{{< tab header="Python" >}}
{{< badge-code >}}
{{< gh-codeblock path="examples/python/tests/virtual_authenticator/virtual_authenticator_test.py#LL40C1-L40C1" >}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you pin the right lines?

And meanwhile, as you signed on the commit description, can you help to sync the part to all languages?
" Code example added (and I also added the example to all translated languages)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants