Changelocatorandinfo #1337
Open
Changelocatorandinfo #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
harsha509
requested changes
Mar 20, 2023
There was a problem hiding this comment.
Hi @pallavigitwork ,
Thank you for the PR. PR looks good to me to get started, but could you please revert the files hugo.toml, package.json and package-lock.json.
| @@ -5,7 +5,7 @@ enableRobotsTXT = true | |||
|
|
|||
| # Will give values to .Lastmod etc. | |||
| enableGitInfo = true | |||
| #ignoreErrors = ["error-remote-getjson"] | |||
| ignoreErrors = ["error-remote-getjson"] | |||
There was a problem hiding this comment.
hi @pallavigitwork ,
This should be commented out.
| "requires": { | ||
| "queue-microtask": "^1.2.2" | ||
| } | ||
| }, | ||
| "slash": { | ||
| "version": "5.0.0", | ||
| "resolved": "https://registry.npmjs.org/slash/-/slash-5.0.0.tgz", | ||
| "integrity": "sha512-n6KkmvKS0623igEVj3FF0OZs1gYYJ0o0Hj939yc1fyxl2xt+xYpLnzJB6xBSqOfV9ZFLEWodBBN/heZJahuIJQ==" | ||
| "integrity": "sha512-n6KkmvKS0623igEVj3FF0OZs1gYYJ0o0Hj939yc1fyxl2xt+xYpLnzJB6xBSqOfV9ZFLEWodBBN/heZJahuIJQ==", | ||
| "dev": true |
There was a problem hiding this comment.
Strange,
How come all packages are added with dev:true and am not sure hugo packages are updated!
|
@pallavigitwork is this PR still valid? |
|
i will check and update you by this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
changed the locator and information document
Description
modified js code
in both documents
Motivation and Context
code got deleted. fixed a vaiable name
Types of changes
Checklist