Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made changes to isdisplay ruby code #1330

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

pallavigitwork
Copy link
Contributor

@pallavigitwork pallavigitwork commented Mar 10, 2023

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@netlify
Copy link

netlify bot commented Mar 10, 2023

Deploy Preview for jovial-austin-42fe02 ready!

Name Link
🔨 Latest commit 58c84cc
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/640b0e04039a020007ace7c6
😎 Deploy Preview https://deploy-preview-1330--jovial-austin-42fe02.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase and solve the conflicts?

This PR is not reflecting the changes you did a while ago 5bdcecb

@diemol
Copy link
Member

diemol commented Feb 19, 2024

@pallavigitwork is this PR still valid?

@pallavigitwork
Copy link
Contributor Author

i will check and update you by this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants