Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test page scrolling #1302

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Test page scrolling #1302

wants to merge 2 commits into from

Conversation

galgal12345
Copy link

@galgal12345 galgal12345 commented Feb 1, 2023

This code opens a Firefox browser, navigates to a desired page, and scrolls down using the arrow keys.   
The code then verifies that the page has been scrolled by checking that the page height has increased.

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

…scrolls down using the arrow keys.

    The code then verifies that the page has been scrolled by checking that the page height has increased.
    Note that you will need to install the Selenium library in order to run this code.
@CLAassistant
Copy link

CLAassistant commented Feb 1, 2023

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Feb 1, 2023

Deploy Preview for jovial-austin-42fe02 ready!

Name Link
🔨 Latest commit cd12508
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/63ede250e79c8a00079847fb
😎 Deploy Preview https://deploy-preview-1302--jovial-austin-42fe02.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where would you link this example in the docs? Any reason why you did not use the same page used for the other tests?

@titusfortner
Copy link
Member

This is an example for how to send a key with actions class. That belongs in the keyboard examples file.

I don't think we want to create examples for the behavior of every specific key? But we could.

As far as scrolling goes, we want to encourage it to be always done with the scroll wheel going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants