Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actually do not camel case fx prefs #9944

Merged
merged 1 commit into from Oct 20, 2021
Merged

actually do not camel case fx prefs #9944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion rb/lib/selenium/webdriver/firefox/options.rb
View file
Open in desktop
Expand Up @@ -175,7 +175,7 @@ def process_profile(profile)
end

def camelize?(key)
key != :prefs
key != "prefs"
end
end # Options
end # Firefox
Expand Down
8 changes: 8 additions & 0 deletions rb/spec/unit/selenium/webdriver/firefox/options_spec.rb
View file
Open in desktop
Expand Up @@ -149,6 +149,14 @@ module Firefox
options.add_preference(:foo, 'bar')
expect(options.prefs[:foo]).to eq('bar')
end

it 'does not camelize preferences' do
options.add_preference('intl.accepted_languages', 'en-US')

prefs = options.as_json['moz:firefoxOptions']['prefs']
expected = { 'intl.accepted_languages' => 'en-US' }
expect(prefs).to eq(expected)
end
end

describe '#enable_android' do
Expand Down