Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Make some classes in internal folder as really to be internal #13331

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

nvborisenko
Copy link
Member

Description

Internal stuff should be internal.

Motivation and Context

Sometimes selenium's classes appears in IDE suggestions, and these classes are supposed to be for internal usage. Like PortUtilities class.. I don't think Selenium is created for networking.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@diemol
Copy link
Member

diemol commented Mar 26, 2024

@nvborisenko can I merge this one? (If CI passes, of course)

@nvborisenko
Copy link
Member Author

Unfortunately no, CI will be failing. I don't know how to configure bazel, need help from @shs96c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants