Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update proxyType values to match w3c spec #13285

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Conversation

titusfortner
Copy link
Member

@titusfortner titusfortner commented Dec 11, 2023

Description

Motivation and Context

Making the libraries consistent between languages and updating to match w3c behavior.

Notes

  • Looking at the JS code, I don't think it needs any changes to match.
  • I'm not sure how much of this can/should be marked deprecated instead of just making these changes to conform to the spec.
  • I was going to remove "Unspecified" as an enum, but it makes sense to keep it I think in Java & .NET because strict, but not as much in Python, so removed to match Ruby & JS implementations

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7cbfdbd) 57.99% compared to head (76f7054) 58.12%.
Report is 3 commits behind head on trunk.

❗ Current head 76f7054 differs from pull request most recent head 04c0159. Consider uploading reports for the commit 04c0159 to get more accurate results

Files Patch % Lines
py/selenium/webdriver/common/proxy.py 66.66% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #13285      +/-   ##
==========================================
+ Coverage   57.99%   58.12%   +0.12%     
==========================================
  Files          88       88              
  Lines        5338     5335       -3     
  Branches      224      224              
==========================================
+ Hits         3096     3101       +5     
+ Misses       2018     2010       -8     
  Partials      224      224              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titusfortner
Copy link
Member Author

I feel like I read something completely different every time I look at the spec:

Otherwise
Set a property of capabilities with name "proxy" and a value that is a new JSON Object.

Grid is deserializing the empty Proxy and failing, so I need to remove the errors I'm throwing here. 😂

@diemol
Copy link
Member

diemol commented Feb 12, 2024

@titusfortner what is left to do here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants