Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spelling mistake from the method name #11051

Merged
merged 1 commit into from Sep 26, 2022
Merged

Remove spelling mistake from the method name #11051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions py/selenium/webdriver/remote/remote_connection.py
View file
Open in desktop
Expand Up @@ -135,7 +135,7 @@ def _identify_http_proxy_auth(self):
url = url[url.find(":") + 3:]
return "@" in url and len(url[:url.find('@')]) > 0

def _seperate_http_proxy_auth(self):
def _separate_http_proxy_auth(self):
url = self._proxy_url
protocol = url[:url.find(":") + 3]
no_protocol = url[len(protocol):]
Expand All @@ -156,7 +156,7 @@ def _get_connection_manager(self):
from urllib3.contrib.socks import SOCKSProxyManager
return SOCKSProxyManager(self._proxy_url, **pool_manager_init_args)
elif self._identify_http_proxy_auth():
self._proxy_url, self._basic_proxy_auth = self._seperate_http_proxy_auth()
self._proxy_url, self._basic_proxy_auth = self._separate_http_proxy_auth()
pool_manager_init_args['proxy_headers'] = urllib3.make_headers(
proxy_basic_auth=self._basic_proxy_auth)
return urllib3.ProxyManager(self._proxy_url, **pool_manager_init_args)
Expand Down
4 changes: 2 additions & 2 deletions py/test/unit/selenium/webdriver/remote/remote_connection_tests.py
View file
Open in desktop
Expand Up @@ -72,7 +72,7 @@ def test_get_proxy_url_none(mock_proxy_settings_missing):
def test_get_proxy_url_http_auth(mock_proxy_auth_settings):
remote_connection = RemoteConnection('http://remote', keep_alive=False)
proxy_url = remote_connection._get_proxy_url()
raw_proxy_url, basic_auth_string = remote_connection._seperate_http_proxy_auth()
raw_proxy_url, basic_auth_string = remote_connection._separate_http_proxy_auth()
assert proxy_url == "http://user:password@http_proxy.com:8080"
assert raw_proxy_url == "http://http_proxy.com:8080"
assert basic_auth_string == "user:password"
Expand All @@ -81,7 +81,7 @@ def test_get_proxy_url_http_auth(mock_proxy_auth_settings):
def test_get_proxy_url_https_auth(mock_proxy_auth_settings):
remote_connection = RemoteConnection('https://remote', keep_alive=False)
proxy_url = remote_connection._get_proxy_url()
raw_proxy_url, basic_auth_string = remote_connection._seperate_http_proxy_auth()
raw_proxy_url, basic_auth_string = remote_connection._separate_http_proxy_auth()
assert proxy_url == "https://user:password@https_proxy.com:8080"
assert raw_proxy_url == "https://https_proxy.com:8080"
assert basic_auth_string == "user:password"
Expand Down