Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Re-enabling browser-actions/setup-geckodriver@latest #11024

Merged
merged 2 commits into from Sep 13, 2022

Conversation

whimboo
Copy link
Contributor

@whimboo whimboo commented Sep 13, 2022

Description

mozilla/geckodriver#2009 got fixed a while ago and getting the latest geckodriver binary is working again.

mozilla/geckodriver#2009 got fixed a while ago and getting
the latest geckodriver binary is working again.
@CLAassistant
Copy link

CLAassistant commented Sep 13, 2022

CLA assistant check
All committers have signed the CLA.

@whimboo
Copy link
Contributor Author

whimboo commented Sep 13, 2022

@titusfortner or @diemol could you please review? Thanks

@titusfortner
Copy link
Member

Ruby & Python weren't even using this so I added it. Let me make sure it runs for everything.

@whimboo
Copy link
Contributor Author

whimboo commented Sep 13, 2022

Ruby & Python weren't even using this so I added it. Let me make sure it runs for everything.

I just noticed that myself for my investigation on #11025. Thanks for getting these added!

@titusfortner
Copy link
Member

We've got a really cool filter to only run builds when changes are made... except it then becomes difficult to force the builds to be run. I've pushed this branch to selenium/latest_geckodriver and am forcing runs just to make sure we have everything.

@codecov-commenter
Copy link

Codecov Report

Merging #11024 (59c175d) into trunk (ffb5026) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            trunk   #11024   +/-   ##
=======================================
  Coverage   53.18%   53.18%           
=======================================
  Files          84       84           
  Lines        5488     5488           
  Branches      272      272           
=======================================
  Hits         2919     2919           
  Misses       2297     2297           
  Partials      272      272           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@titusfortner titusfortner merged commit 59c175d into SeleniumHQ:trunk Sep 13, 2022
@titusfortner
Copy link
Member

Verified this works, thanks!

@whimboo whimboo deleted the latest_geckodriver branch September 13, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants