Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rb] Add secure websocket support for Devtools #10023

Closed
wants to merge 3 commits into from

Conversation

pujagani
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Add secure websocket support for Devtools

Motivation and Context

Related to ##10017.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@titusfortner titusfortner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping in to fix this. @p0deje is the expert in this code, but I'd like to request we keep the memoization.

Something like this:

def socket
  @socket ||= URI.parse(@url).scheme == 'wss' ? create_ssl_socket : TCPSocket.new(ws.host, ws.port)
end

@p0deje p0deje self-assigned this Nov 13, 2021
@sonarcloud
Copy link

sonarcloud bot commented Nov 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@p0deje
Copy link
Member

p0deje commented Nov 17, 2021

Thank you! Merged in e0d8d957665f9203ad487fb6d54f26c7b822ad7a

@p0deje p0deje closed this Nov 17, 2021
@p0deje
Copy link
Member

p0deje commented Nov 17, 2021

Sorry, 560a0ae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants